linux-kernel - Re: [PATCH v3] staging: pi433: replace simple switch statements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180625123554.dlpgejqmjm7haak4@mwanda>
Date:   Mon, 25 Jun 2018 15:35:54 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Valentin Vidic <Valentin.Vidic@...Net.hr>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org, Derek Robson <robsonde@...il.com>,
        Michael Panzlaff <michael.panzlaff@....de>,
        Hugo Lefeuvre <hle@....eu.com>,
        Luca Söthe <luca@...l.me>,
        linux-kernel@...r.kernel.org,
        Marcin Ciupak <marcin.s.ciupak@...il.com>,
        Marcus Wolf <linux@...f-Entwicklungen.de>,
        Simon Sandström <simon@...anor.nu>,
        Joe Perches <joe@...ches.com>
Subject: Re: [PATCH v3] staging: pi433: replace simple switch statements

I'd still prefer if we just removed this abstraction entirely and used
OPMODE_MODE_TRANSMIT everywhere instead of bringing "transmit" into it.

I know that every author thinks their abstraction will definitely be
useful in the future, but generally kernel style is to remove
abstractions.

But I guess this code is an improvement over the original so the patch
is fine.

regards,
dan carpenter