linux-kernel - Re: [PATCH] arch/x86: get rid of KERN_CONT in show_fault

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACT4Y+ZZVOjec2dvRCU9p7MHkbYyjqk7FMr4Yu3ahVyL_g0YGQ@mail.gmail.com>
Date:   Mon, 25 Jun 2018 14:40:00 +0200
From:   Dmitry Vyukov <dvyukov@...gle.com>
To:     Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
Cc:     Andy Shevchenko <andy.shevchenko@...il.com>,
        Dmitry Vyukov <dvyukov@...il.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arch/x86: get rid of KERN_CONT in show_fault_oops()

On Thu, Jun 21, 2018 at 10:17 AM, Sergey Senozhatsky
<sergey.senozhatsky.work@...il.com> wrote:
> On (06/21/18 09:59), Dmitry Vyukov wrote:
>> >
>> >> +       printk(KERN_ALERT "BUG: unable to handle kernel %s at %px\n",
>> >> +               (address < PAGE_SIZE ? "NULL pointer dereference" :
>> >> +               "paging request"), (void *) address);
>> >
>> > Perhaps pr_alert() ?
>>
>> It's the same, right? Make sense.
>
> Right.
>
> In printk(KERN_<LEVEL> ...) people tend to forget KERN_<LEVEL> sometimes,
> so, I think, in general we want to see more pr_foo() and less printk().

Mailed v2 with pr_alert().

Since nobody else commented on single pr_alert() with ternary operator
vs if + 2 pr_alert()'s, I left it intact for now.