linux-kernel - Re: [PATCH v2] drivers: base: initcall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180625152055.GA23270@rob-hp-laptop>
Date:   Mon, 25 Jun 2018 09:20:55 -0600
From:   Rob Herring <robh@...nel.org>
To:     Todd Poynor <toddpoynor@...il.com>
Cc:     Frank Rowand <frowand.list@...il.com>, devicetree@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, kernel-team@...roid.com,
        Todd Poynor <toddpoynor@...gle.com>
Subject: Re: [PATCH v2] drivers: base: initcall_debug logs for driver probe
 times

On Wed, Jun 20, 2018 at 05:35:56PM -0700, Todd Poynor wrote:
> From: Todd Poynor <toddpoynor@...gle.com>
> 
> Add initcall_debug logs for each driver device probe call, for example:
> 
>    probe of a3800000.ramoops returned 1 after 3007 usecs
> 
> This replaces the previous code added to report times for deferred
> probes.  It also reports OF platform bus device creates that were
> formerly lumped together in a single entry for function
> of_platform_default_populate_init, as well as helping to annotate other
> initcalls that involve device probing.
> 
> Remove restriction on printing probe times only during initcalls, since
> initcall_debug now continues to show driver timing info past the boot
> phase.
> 
> Signed-off-by: Todd Poynor <toddpoynor@...gle.com>
> ---
>  drivers/base/dd.c | 50 +++++++++++++++++++++--------------------------
>  1 file changed, 22 insertions(+), 28 deletions(-)
> 
> Changes from v1:
> * unsigned long long -> s64
> * use ktime_to_us() instead of ktime_to_ns with shift
> * print probe return value
> * drop code that stopped output on end of initcall processing

Reviewed-by: Rob Herring <robh@...nel.org>