linux-kernel - Re: checkpatch false positive (IMO): typo detected in truncated commit message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <35b62e21e0de223acae0f9f468212ee9638c3544.camel@perches.com>
Date:   Mon, 25 Jun 2018 08:23:42 -0700
From:   Joe Perches <joe@...ches.com>
To:     Jann Horn <jannh@...gle.com>, Andy Whitcroft <apw@...onical.com>
Cc:     LKML <linux-kernel@...r.kernel.org>
Subject: Re: checkpatch false positive (IMO): typo detected in truncated
 commit message

On Mon, 2018-06-25 at 17:22 +0200, Jann Horn wrote:
> Hello!
> 
> I got the following message from checkpatch:
> 
> =======
> $ scripts/checkpatch.pl
> 0001-netfilter-nf_log-don-t-hold-nf_log_mutex-during-user.patch
> WARNING: 'calle' may be misspelled - perhaps 'called'?
> #15:
> Fixes: 266d07cb1c9a ("netfilter: nf_log: fix sleeping function calle[...]")
> 
> total: 0 errors, 1 warnings, 0 checks, 20 lines checked
> 
> NOTE: For some of the reported defects, checkpatch may be able to
>       mechanically convert to the typical style using --fix or --fix-inplace.
> 
> 0001-netfilter-nf_log-don-t-hold-nf_log_mutex-during-user.patch has
> style problems, please review.
> 
> NOTE: If any of the errors are false positives, please report
>       them to the maintainer, see CHECKPATCH in MAINTAINERS.
> =======
> 
> I believe that it is appropriate here to truncate the commit message
> of the fixed commit.

It's not.