linux-kernel - Re: [PATCH] x86/vdso: Change return type to vm_fault

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALCETrU3dS5t714BYqkxEYgkbJaESK6NP1Rsn3xq3En38yjJzQ@mail.gmail.com>
Date:   Mon, 25 Jun 2018 09:11:36 -0700
From:   Andy Lutomirski <luto@...capital.net>
To:     jrdr.linux@...il.com
Cc:     Matthew Wilcox <willy@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>, X86 ML <x86@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>, brajeswar.linux@...il.com,
        sabyasachi.linux@...il.com
Subject: Re: [PATCH] x86/vdso: Change return type to vm_fault_t for fault handlers

On Mon, Jun 25, 2018 at 8:55 AM Souptick Joarder <jrdr.linux@...il.com> wrote:
>
> Use new return type vm_fault_t for fault handler. For
> now, this is just documenting that the function returns
> a VM_FAULT value rather than an errno. Once all instances
> are converted, vm_fault_t will become a distinct type.

Whoa there..  Your commit message makes it sound like you're just
changing the return type, but:

>                 if (tsc_pg && vclock_was_used(VCLOCK_HVCLOCK))
> -                       ret = vm_insert_pfn(vma, vmf->address,
> +                       ret = vmf_insert_pfn(vma, vmf->address,
>                                             vmalloc_to_pfn(tsc_pg));
>         }
>
> -       if (ret == 0 || ret == -EBUSY)
> -               return VM_FAULT_NOPAGE;
> -
> -       return VM_FAULT_SIGBUS;
> +       return ret;

You're refactoring the code, too.

Please fix your changelog.