linux-kernel - Re: [PATCH 1/2] slimbus: stream: add stream support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <531e49bb-cdc9-610f-1bad-bd40f633e90d@linaro.org>
Date:   Mon, 25 Jun 2018 17:30:48 +0100
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Vinod <vkoul@...nel.org>
Cc:     gregkh@...uxfoundation.org, broonie@...nel.org,
        sdharia@...cinc.com, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, alsa-devel@...a-project.org,
        ctatlor97@...il.com
Subject: Re: [PATCH 1/2] slimbus: stream: add stream support



On 25/06/18 17:21, Vinod wrote:
>>>> +/*
>>>> + * slim_stream_enable() - Enable a prepared SLIMbus Stream
>>> Do you want to check if it is already prepared ..?
>> Yep, I think most of the code needs similar state machine check, I will add
>> this in next version.
> so if you are tying to snd stream states then I don't think you need a
> state machine here. ALSA already does that for you so you can skip it :D
Stream state machine looks redundant, I will try to skip it and see how 
things look at the end! before sending next version.

thanks,
srini