linux-kernel - Re: [PATCH V2 2/2] efi/fb: Convert PCI bus address to resource if translated by the bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKv+Gu__a0yMcH6pyC0oxXZYgi=emuJA+6v1Zdmd4tbq_UR0Og@mail.gmail.com>
Date:   Mon, 25 Jun 2018 19:29:21 +0200
From:   Ard Biesheuvel <ard.biesheuvel@...aro.org>
To:     Sinan Kaya <okaya@...eaurora.org>
Cc:     Bjorn Helgaas <helgaas@...nel.org>,
        "open list:EFIFB FRAMEBUFFER DRIVER" <linux-fbdev@...r.kernel.org>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        linux-arm-msm@...r.kernel.org, Timur Tabi <timur@...eaurora.org>,
        open list <linux-kernel@...r.kernel.org>,
        "open list:FRAMEBUFFER LAYER" <dri-devel@...ts.freedesktop.org>,
        Peter Jones <pjones@...hat.com>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH V2 2/2] efi/fb: Convert PCI bus address to resource if
 translated by the bridge

On 25 June 2018 at 19:28, Sinan Kaya <okaya@...eaurora.org> wrote:
> On 6/25/2018 11:52 AM, okaya@...eaurora.org wrote:
>>> Note that this is not the only MMIO translation related change made by
>>> Heyi Guo to the generic PCI host bridge and bus drivers, but given
>>> that those did not support MMIO translation at all, I take it your
>>> affected platforms will already have their own changes to accommodate
>>> this.
>>
>> Platform has been doing mmio translation for quite a while. Because all accesses go through pci io protocol, the rest of the UEFI never needed to be aware of bar address or do direct access.
>>
>> This is the first time I hear of direct access. Maybe, GOP is a special case.
>>
>> I started copying your response to the bios vendor.
>>
>> They are probably missing that patch. I will pass it along.
>
> I was informed that they fixed the issue in BIOS by presenting CPU physical
> address instead of PCI bus address in FrameBufferBase of the AST GOP UEFI driver.
>
> We can drop this patch now.
>

Excellent! Thanks for following up with the vendor ...