linux-kernel - RE: [PATCH v6] tpm: separate cmd_ready/go_idle from runtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B9D9539B6@hasmsx108.ger.corp.intel.com>
Date:   Mon, 25 Jun 2018 18:54:13 +0000
From:   "Winkler, Tomas" <tomas.winkler@...el.com>
To:     Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
CC:     Jason Gunthorpe <jgg@...pe.ca>,
        "Usyskin, Alexander" <alexander.usyskin@...el.com>,
        "linux-integrity@...r.kernel.org" <linux-integrity@...r.kernel.org>,
        "linux-security-module@...r.kernel.org" 
        <linux-security-module@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: RE: [PATCH v6] tpm: separate cmd_ready/go_idle from runtime_pm


> 
> On Thu, 2018-06-21 at 18:40 +0000, Winkler, Tomas wrote:
> > I just wanted to make sure that 'RAW' not used in the api directly, it
> > will break the flow, do have any suggestion to make it obvious.
> 
> We will look at each code review as for any other peace of code how this flag
> is used and make decisions at that point what is legit use and what is not.

This is not about code review, there is a design decision to hide it, this is the API.
Please reconsider.
Thanks
Tomas