linux-kernel - Re: [PATCH v3 3/4] staging: rtl8723bs: use ether_addr_copy() in rtw_macaddr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2a49e8e7-15ef-af4f-1039-b15ae60df11b@gmail.com>
Date:   Tue, 26 Jun 2018 22:32:09 +0200
From:   Michael Straube <straube.linux@...il.com>
To:     Joe Perches <joe@...ches.com>,
        Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: [PATCH v3 3/4] staging: rtl8723bs: use ether_addr_copy() in
 rtw_macaddr_cfg()


On 06/26/18 22:17, Joe Perches wrote:
> On Tue, 2018-06-26 at 21:44 +0200, Michael Straube wrote:
>> On 06/26/18 19:32, Andy Shevchenko wrote:
>>> On Tue, Jun 26, 2018 at 11:14 AM, Michael Straube
>>> <straube.linux@...il.com> wrote:
>>>> Use ether_addr_copy() instead of memcpy() to copy the mac address.
>>>>
>>>
>>> Suggested-by ?
>>>
>>
>> I'll add it. Sorry, I was not aware of the Suggested-by tag.
>>
>>> Btw, ensure that the source and destination buffers are aligned to u16
>>> as required by API.
>>
>> To be honest I'm not sure how to do that excactly.
>>
>> Use __align(2) in the array declarations? e.g.:
>>
>>           u8 mac[ETH_ALEN] __align(2);
> 
> All initial function automatics are naturally aligned.
>>
So there is nothing to change? Now I'm confused.