linux-kernel - RE: [PATCH] fman: don't set node on dpaa-ethernet platform device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AM6PR04MB40085FE9AED3D8698FF505B6EC490@AM6PR04MB4008.eurprd04.prod.outlook.com>
Date:   Tue, 26 Jun 2018 07:00:56 +0000
From:   Madalin-cristian Bucur <madalin.bucur@....com>
To:     David Miller <davem@...emloft.net>,
        "bas@...dalean.ai" <bas@...dalean.ai>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] fman: don't set node on dpaa-ethernet platform device

> -----Original Message-----
> From: David Miller [mailto:davem@...emloft.net]
> Sent: Saturday, June 23, 2018 4:27 AM
> To: bas@...dalean.ai
> Cc: netdev@...r.kernel.org; Madalin-cristian Bucur <madalin.bucur@....com>;
> linux-kernel@...r.kernel.org
> Subject: Re: [PATCH] fman: don't set node on dpaa-ethernet platform device
> 
> From: Bas Vermeulen <bas@...dalean.ai>
> Date: Thu, 21 Jun 2018 13:42:22 +0200
> 
> > Setting dev->node to the mac_node in dpaa_eth_add_device during probe
> > causes the mac_probe to be called again for the dpaa-ethernet.* device
> > that was just added.
> >
> > Fix this by not setting dev->node, as it is not needed.
> >
> > Signed-off-by: Bas Vermeulen <bas@...dalean.ai>
> 
> This patch doesn't apply to the current sources.

Hi,

The line the patch is trying to remove was added in this commit

	commit a1a50c8e4c241a505b7270e1a3c6e50d94e794b1
	Author: Florian Fainelli <f.fainelli@...il.com>
	Date:   Tue Aug 22 15:24:47 2017 -0700

	    fsl/man: Inherit parent device and of_node

and was already removed in this commit

	commit 48167c9ce0b91c068430345bf039c7be23fa2f3f
	Author: Madalin Bucur <madalin.bucur@....com>
	Date:   Mon Oct 16 21:36:05 2017 +0300

	    fsl/fman: remove of_node

Regards,
Madalin