linux-kernel - Re: moving affs + RDB partition support to staging?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1954225.EY2fU3p6yy@merkaba>
Date:   Tue, 26 Jun 2018 10:12:21 +0200
From:   Martin Steigerwald <martin@...htvoll.de>
To:     jdow <jdow@...thlink.net>
Cc:     Michael Schmitz <schmitzmic@...il.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Matthew Wilcox <willy@...radead.org>,
        David Sterba <dsterba@...e.cz>,
        Linux FS Devel <linux-fsdevel@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Jens Axboe <axboe@...nel.dk>,
        linux-m68k <linux-m68k@...ts.linux-m68k.org>
Subject: Re: moving affs + RDB partition support to staging?

Joanne.

jdow - 26.06.18, 07:17:
> As long as it preserves compatibility it should be OK, I suppose.
> Personally I'd make any partitioning tool front end gently force the
> block size towards 8k as the disk size gets larger. The file systems
> may also run into 2TB issues that are not obvious. An unused blocks
> list will have to go beyond a uint32_t size, for example. But a block
> list (OFS for sure, don't remember for the newer AFS) uses a tad
> under 1% of the disk all by itself. A block bitmap is not quite so
> bad. {^_-}
> 
> Just be sure you are aware of all the ramifications when you make a
> change. I remember thinking about this for awhile and then
> determining I REALLY did not want to think about it as my brain was
> getting tied into a gordian knot.

Heh… :)

Well, all I can say it that it just worked on AmigaOS 4. I did not see 
any data corruption in any of the filesystems. Well as far as I have 
been able to check. There has been no repair tool for JXFS I think. But 
as I migrated the data on it to SFS, I was able to copy everything.

Famous last words.

Well especially the disk size was detected properly and there was no 
overflow like on Linux. So I´d say rather have on error less than one 
error more.

Of course, it could also be an option to outright *refuse* to detect 
such disks with a big fat warning in kernel log that it may unsafe. But 
overflowing and thus on writes overwriting existing data is not safe.

I do think it is safe enough, but what I do know about the internals 
about RDB (more than the average user certainly, but not as much as you 
or some other AmigaOS developer who digged  deeper into that).

So in case you´d rather see Linux to refuse to handle disks like that, 
that would also be fine with me. Just do not handle them in the broken 
way that they are handled in Linux now. I.e. do not deliberately corrupt 
things as in "Its dangerous, so let´s overwrite data straight away, so 
the user gets it." :)

Anyway, in my opinion RDB still just so much more advanced than MBR and 
in some parts even on par with the much later GPT. With some limitations 
it is a quite brilliant partition format, if you ask me.

> {^_^}
> 
> On 20180625 19:23, Michael Schmitz wrote:
> > Joanne,
> > 
> > Martin's boot log (including your patch) says:
> > 
> > Jun 19 21:19:09 merkaba kernel: [ 7891.843284]  sdb: RDSK (512) sdb1
> > (LNX^@)(res 2 spb 1) sdb2 (JXF^D)(res 2 spb 1) sdb3 (DOS^C)(res 2
> > spb
> > 4)
> > Jun 19 21:19:09 merkaba kernel: [ 7891.844055] sd 7:0:0:0: [sdb]
> > Attached SCSI disk
> > 
> > so it's indeed a case of self inflicted damage (RDSK (512) means 512
> > byte blocks) and can be worked around by using a different block
> > size.
> > 
> > Your memory serves right indeed - blocksize is in 512 bytes units.
> > I'll still submit a patch to Jens anyway as this may bite others
> > yet.
> > 
> > Cheers,
> > 
> >    Michael
> > 
> > On Sun, Jun 24, 2018 at 11:40 PM, jdow <jdow@...thlink.net> wrote:
> >> BTW - anybody who uses 512 byte blocks with an Amiga file system is
> >> a famn dool.
> >> 
> >> If memory serves the RDBs think in blocks rather than bytes so it
> >> should work up to 2 gigablocks whatever your block size is. 512
> >> blocks is 2199023255552 bytes. But that wastes just a WHOLE LOT of
> >> disk in block maps. Go up to 4096 or 8192. The latter is 35 TB.
> >> 
> >> {^_^}
> >> 
> >> On 20180624 02:06, Martin Steigerwald wrote:
> >>> Hi.
> >>> 
> >>> Michael Schmitz - 27.04.18, 04:11:
> >>>> test results at https://bugzilla.kernel.org/show_bug.cgi?id=43511
> >>>> indicate the RDB parser bug is fixed by the patch given there, so
> >>>> if
> >>>> Martin now submits the patch, all should be well?
> >>> 
> >>> Ok, better be honest than having anyone waiting for it:
> >>> 
> >>> I do not care enough about this, in order to motivate myself
> >>> preparing the a patch from Joanne Dow´s fix.
> >>> 
> >>> I am not even using my Amiga boxes anymore, not even the Sam440ep
> >>> which I still have in my apartment.
> >>> 
> >>> So RDB support in Linux it remains broken for disks larger 2 TB,
> >>> unless someone else does.
> >>> 
> >>> Thanks.
[…]
-- 
Martin