linux-kernel - Re: [PATCH v4] bpf: attach type BPF_LIRC_MODE2 should not depend on CONFIG_CGROUP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <57baf751-cd2a-dedf-05bc-9ac3b4e050be@iogearbox.net>
Date:   Tue, 26 Jun 2018 12:03:35 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Sean Young <sean@...s.org>, Y Song <ys114321@...il.com>,
        Matthias Reichl <hias@...us.com>, linux-media@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        netdev <netdev@...r.kernel.org>,
        Devin Heitmueller <dheitmueller@...nellabs.com>,
        Quentin Monnet <quentin.monnet@...ronome.com>
Subject: Re: [PATCH v4] bpf: attach type BPF_LIRC_MODE2 should not depend on
 CONFIG_CGROUP_BPF

On 06/19/2018 01:04 AM, Sean Young wrote:
> If the kernel is compiled with CONFIG_CGROUP_BPF not enabled, it is not
> possible to attach, detach or query IR BPF programs to /dev/lircN devices,
> making them impossible to use. For embedded devices, it should be possible
> to use IR decoding without cgroups or CONFIG_CGROUP_BPF enabled.
> 
> This change requires some refactoring, since bpf_prog_{attach,detach,query}
> functions are now always compiled, but their code paths for cgroups need
> moving out. Rather than a #ifdef CONFIG_CGROUP_BPF in kernel/bpf/syscall.c,
> moving them to kernel/bpf/cgroup.c and kernel/bpf/sockmap.c does not
> require #ifdefs since that is already conditionally compiled.
> 
> Signed-off-by: Sean Young <sean@...s.org>

Applied to bpf, thanks Sean!