linux-kernel - Re: [PATCH] writeback: update stale account_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180626120624.duicgmjjmzhpqao4@quack2.suse.cz>
Date:   Tue, 26 Jun 2018 14:06:24 +0200
From:   Jan Kara <jack@...e.cz>
To:     Greg Thelen <gthelen@...gle.com>
Cc:     Tejun Heo <tj@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Jan Kara <jack@...e.cz>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] writeback: update stale account_page_redirty() comment

On Mon 25-06-18 10:15:26, Greg Thelen wrote:
> commit 93f78d882865 ("writeback: move backing_dev_info->bdi_stat[] into
> bdi_writeback") replaced BDI_DIRTIED with WB_DIRTIED in
> account_page_redirty().  Update comment to track that change.
>   BDI_DIRTIED => WB_DIRTIED
>   BDI_WRITTEN => WB_WRITTEN
> 
> Signed-off-by: Greg Thelen <gthelen@...gle.com>

Looks good. You can add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  mm/page-writeback.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/page-writeback.c b/mm/page-writeback.c
> index 337c6afb3345..6551d3b0dc30 100644
> --- a/mm/page-writeback.c
> +++ b/mm/page-writeback.c
> @@ -2490,8 +2490,8 @@ EXPORT_SYMBOL(__set_page_dirty_nobuffers);
>  
>  /*
>   * Call this whenever redirtying a page, to de-account the dirty counters
> - * (NR_DIRTIED, BDI_DIRTIED, tsk->nr_dirtied), so that they match the written
> - * counters (NR_WRITTEN, BDI_WRITTEN) in long term. The mismatches will lead to
> + * (NR_DIRTIED, WB_DIRTIED, tsk->nr_dirtied), so that they match the written
> + * counters (NR_WRITTEN, WB_WRITTEN) in long term. The mismatches will lead to
>   * systematic errors in balanced_dirty_ratelimit and the dirty pages position
>   * control.
>   */
> -- 
> 2.18.0.rc2.346.g013aa6912e-goog
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR