linux-kernel - Re: [PATCH v2 2/2] eeprom: at24: Add support for address-width property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c4ad247dd1e0b4b13a2ca4e822bc569675556a7d.camel@linux.intel.com>
Date:   Tue, 26 Jun 2018 15:11:43 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     "Chiang, AlanX" <alanx.chiang@...el.com>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>
Cc:     "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
        "Yeh, Andy" <andy.yeh@...el.com>,
        "Mani, Rajmohan" <rajmohan.mani@...el.com>,
        "andy.shevchenko@...il.com" <andy.shevchenko@...il.com>,
        "brgl@...ev.pl" <brgl@...ev.pl>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "arnd@...db.de" <arnd@...db.de>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] eeprom: at24: Add support for address-width
 property

On Tue, 2018-06-26 at 15:11 +0800, Chiang, AlanX wrote:

> If it is, I would like to modify it as below:
> 
> case 8:
> 	If (chip->flags & AT24_FLAG_ADDR16) {
> 		chip->flags &= ~AT24_FLAG_ADDR16;
> 		dev_warn(dev, "address-width is 8, clear the ADDR16
> bit\n");
> 	}
> 	break;

No need to put bit clearing inside the loop, something like below would
be slightly better.

if (chip->flags & AT24_FLAG_ADDR16)
	dev_warn(dev, "address-width is 8, clear the ADDR16 bit\n");
chip->flags &= ~AT24_FLAG_ADDR16;

On top of this the message would sound clearer if you put it like

"Override address width to be 8, while default is 16"

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy