linux-kernel - Re: [PATCH v5 4/5] ima: Use tpm_default_chip() and call TPM functions with a tpm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fbf7822a1c6a07adad22a5afbb0eb4de48e2d48e.camel@linux.intel.com>
Date:   Tue, 26 Jun 2018 16:25:44 +0300
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     Stefan Berger <stefanb@...ux.vnet.ibm.com>,
        linux-integrity@...r.kernel.org, zohar@...ux.vnet.ibm.com
Cc:     jgg@...pe.ca, linux-kernel@...r.kernel.org,
        linux-security-module@...r.kernel.org
Subject: Re: [PATCH v5 4/5] ima: Use tpm_default_chip() and call TPM
 functions with a tpm_chip

On Tue, 2018-06-26 at 07:06 -0400, Stefan Berger wrote:
> Rather than accessing the TPM functions by passing a NULL pointer for
> the tpm_chip, which causes a lookup for a suitable chip every time, get a
> hold of a tpm_chip and access the TPM functions using it.
> 
> Signed-off-by: Stefan Berger <stefanb@...ux.vnet.ibm.com>

Acked-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>

(i.e. LGTM but competence to give a detailed review).

/Jarkko