linux-kernel - Re: [PATCH] irqchip/ls-scfg-msi: update effective affinity mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8e4b85b7-f75f-aa9c-1baa-837f66906cee@nxp.com>
Date:   Tue, 26 Jun 2018 15:21:47 +0000
From:   Laurentiu Tudor <laurentiu.tudor@....com>
To:     Marc Zyngier <marc.zyngier@....com>
CC:     "tglx@...utronix.de" <tglx@...utronix.de>,
        "jason@...edaemon.net" <jason@...edaemon.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "M.h. Lian" <minghuan.lian@....com>,
        "Z.q. Hou" <zhiqiang.hou@....com>
Subject: Re: [PATCH] irqchip/ls-scfg-msi: update effective affinity mask

Hi Marc,

On 26.06.2018 17:56, Marc Zyngier wrote:
> On Tue, 26 Jun 2018 15:37:12 +0100,
> Laurentiu Tudor <laurentiu.tudor@....com> wrote:
>>
>> Update the effective affinity mask to fix this warning issued by the
>> generic irq handling code:
>>
>> "genirq: irq_chip MSI did not update eff. affinity mask of irq x"
>>
>> Signed-off-by: Laurentiu Tudor <laurentiu.tudor@....com>
>> ---
>>   drivers/irqchip/irq-ls-scfg-msi.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/irqchip/irq-ls-scfg-msi.c b/drivers/irqchip/irq-ls-scfg-msi.c
>> index 1ec3bfe56693..d81d5b016438 100644
>> --- a/drivers/irqchip/irq-ls-scfg-msi.c
>> +++ b/drivers/irqchip/irq-ls-scfg-msi.c
>> @@ -122,6 +122,7 @@ static int ls_scfg_msi_set_affinity(struct irq_data *irq_data,
>>   	}
>>   
>>   	cpumask_copy(irq_data->common->affinity, mask);
>> +	irq_data_update_effective_affinity(irq_data, mask);
>>   
>>   	return IRQ_SET_MASK_OK;
>>   }
> 
> It has already been addressed here:
> 

Thanks for the obviously much better & complete fix.
Will take care to keep my local repo more up-to-date.

---
Best Regards, Laurentiu