linux-kernel - Re: [PATCH v2] gpu: drm: armada: Adding new typedef vm_fault

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180626153740.GA17271@n2100.armlinux.org.uk>
Date:   Tue, 26 Jun 2018 16:37:40 +0100
From:   Russell King - ARM Linux <linux@...linux.org.uk>
To:     Souptick Joarder <jrdr.linux@...il.com>
Cc:     airlied@...ux.ie, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org, Matthew Wilcox <willy@...radead.org>
Subject: Re: [PATCH v2] gpu: drm: armada: Adding new typedef vm_fault_t

On Tue, Jun 19, 2018 at 10:42:15AM +0530, Souptick Joarder wrote:
> On Mon, Jun 4, 2018 at 10:46 AM, Souptick Joarder <jrdr.linux@...il.com> wrote:
> > On Wed, May 23, 2018 at 3:09 PM, Souptick Joarder <jrdr.linux@...il.com> wrote:
> >> On Wed, May 16, 2018 at 10:05 AM, Souptick Joarder <jrdr.linux@...il.com> wrote:
> >>> On Fri, May 11, 2018 at 2:52 PM, Russell King - ARM Linux
> >>> <linux@...linux.org.uk> wrote:
> >>>> On Thu, May 10, 2018 at 08:34:48PM +0530, Souptick Joarder wrote:
> >>>>> Use new return type vm_fault_t for fault handler in
> >>>>> struct vm_operations_struct. For now, this is just
> >>>>> documenting that the function returns a VM_FAULT
> >>>>> value rather than an errno. Once all instances are
> >>>>> converted, vm_fault_t will become a distinct type.
> >>>>>
> >>>>> commit 1c8f422059ae ("mm: change return type to vm_fault_t")
> >>>>>
> >>>>> Previously vm_insert_pfn() returns err which driver
> >>>>> mapped into VM_FAULT_* type. The new function
> >>>>> vmf_insert_pfn() will replace this inefficiency by
> >>>>> returning VM_FAULT_* type.
> >>>>>
> >>>>> Signed-off-by: Souptick Joarder <jrdr.linux@...il.com>
> >>>>> Reviewed-by: Matthew Wilcox <mawilcox@...rosoft.com>
> >>>>
> >>>> Acked-by: Russell King <rmk+kernel@...linux.org.uk>
> >>>>
> >>>> Thanks.
> >>>
> >>> If no further comment, we would like to get this patch in queue
> >>> for 4.18.
> >>
> >> We would like to get this patch in queue
> >> for 4.18.
> >
> > We  would like to get this patch in 4.18.
> 
> Russell, This patch is not merged in 4.18-rc-1.

Correct, I wasn't able to add it to my tree because David Airlie hadn't
pulled the previous merge request, so it missed the 4.18 merge window.

The reason for me acking the patch was so that /someone else/ could
pick it up instead, and that obviously also didn't happen - maybe the
drm-misc tree was closed for new work at the point you sent the patch.

I've picked this patch up now, thanks.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up