linux-kernel - Re: [PATCH] ARM: dts: pxa: fix the rtc controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_JsqLo5ntGLLZzssCJo7g--WWvgZLkX0vTV0VOT7a5H0QLFg@mail.gmail.com>
Date:   Tue, 26 Jun 2018 12:22:54 -0600
From:   Rob Herring <robh+dt@...nel.org>
To:     Robert Jarzmik <robert.jarzmik@...e.fr>
Cc:     Daniel Mack <daniel@...que.org>,
        Haojian Zhuang <haojian.zhuang@...il.com>,
        Mark Rutland <mark.rutland@....com>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>, devicetree@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARM: dts: pxa: fix the rtc controller

On Tue, Jun 26, 2018 at 10:47 AM Robert Jarzmik <robert.jarzmik@...e.fr> wrote:
>
> The RTC controller is fed by an external fixed 32kHz clock. Yet the
> driver wants to acquire this clock, even though it doesn't make any use
> of it, ie. doesn't get the rate to make calculation.
>
> Therefore, add the dummy clock in the PXA clock tree to make the driver
> happy and working.
>
> Signed-off-by: Robert Jarzmik <robert.jarzmik@...e.fr>
> ---
>  arch/arm/boot/dts/pxa25x.dtsi | 4 ++++
>  arch/arm/boot/dts/pxa27x.dtsi | 4 ++++
>  2 files changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/pxa25x.dtsi b/arch/arm/boot/dts/pxa25x.dtsi
> index 95d59be97213..c6ca07e4626b 100644
> --- a/arch/arm/boot/dts/pxa25x.dtsi
> +++ b/arch/arm/boot/dts/pxa25x.dtsi
> @@ -80,6 +80,10 @@
>                         #pwm-cells = <1>;
>                         clocks = <&clks CLK_PWM1>;
>                 };
> +
> +               rtc@...00000 {
> +                       clocks = <&clks CLK_NONE>;

Don't add fake clocks. Either add a real clock or fix the driver to
not require a clock.

Rob