linux-kernel - Re: [PATCH v3 2/3] fbcon: Call WARN_CONSOLE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <91a98281-979f-9479-a31a-363243948372@redhat.com>
Date:   Tue, 26 Jun 2018 20:29:07 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Petr Mladek <pmladek@...e.com>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/3] fbcon: Call WARN_CONSOLE_UNLOCKED() where
 applicable

Hi,

On 26-06-18 16:47, Steven Rostedt wrote:
> On Tue, 26 Jun 2018 15:55:34 +0200
> Hans de Goede <hdegoede@...hat.com> wrote:
> 
>> Replace comments about places where the console lock should be held with
>> calls to WARN_CONSOLE_UNLOCKED() to assert that it is actually held.
> 
> Why replace the comments? I prefer them, even with the WARN. The reason
> is, when using functions, I don't tend to look inside the function I'm
> about to use, but instead, I expect the comment above the function to
> have basic information I need to use it. Especially what locks are
> expected to be held.
> 
> Please keep the comments in place, but the WARNs are fine. They are not
> a replacement for the comments.
> 
> Nack on removing comments.

Ok, I will submit a v4 with the comments left in place.

Regards,

Hans