linux-kernel - Re: [PATCH v2] mtd: rawnand: mxc: remove __init qualifier from mxcnd_probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180627110115.490a2477@xps13>
Date:   Wed, 27 Jun 2018 11:01:15 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Martin Kaiser <martin@...ser.cx>
Cc:     Boris Brezillon <boris.brezillon@...tlin.com>,
        David Woodhouse <dwmw2@...radead.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Fabio Estevam <fabio.estevam@....com>,
        linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mtd: rawnand: mxc: remove __init qualifier from
 mxcnd_probe_dt

Hi Martin,

On Wed, 27 Jun 2018 10:52:37 +0200, Martin Kaiser <martin@...ser.cx>
wrote:

> Using the sysfs unbind, bind nodes, mxcnd_probe and mxcnd_probe_dt can
> potentially be called at any time. After the __init functions are cleaned,
> mxcnd_probe_dt is no longer available. Calling it anyway causes a crash.
> 
> mxcnd_probe used to be marked as __init, this was removed years ago.
> Remove the __init qualifier from from mxcnd_probe_dt as well.
> 
> Fixes: 06f2551 ("mtd: remove use of __devinit")

Nitpick: the Fixes tag should use at least the 12 first characters of
the SHA-1 ID, see:

https://www.kernel.org/doc/html/v4.16/process/submitting-patches.html#describe-your-changes

Thanks,
Miquèl