linux-kernel - RE: [PATCH] ARM: dts: make pfuze switch always-on for imx platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DB5PR04MB1320492352AFFEB852E74D1AF5480@DB5PR04MB1320.eurprd04.prod.outlook.com>
Date:   Wed, 27 Jun 2018 01:23:01 +0000
From:   Anson Huang <anson.huang@....com>
To:     Fabio Estevam <festevam@...il.com>
CC:     Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Sascha Hauer <kernel@...gutronix.de>,
        Fabio Estevam <fabio.estevam@....com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        dl-linux-imx <linux-imx@....com>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] ARM: dts: make pfuze switch always-on for imx platforms



Anson Huang
Best Regards!


> -----Original Message-----
> From: Fabio Estevam [mailto:festevam@...il.com]
> Sent: Wednesday, June 27, 2018 9:21 AM
> To: Anson Huang <anson.huang@....com>
> Cc: Shawn Guo <shawnguo@...nel.org>; Sascha Hauer
> <s.hauer@...gutronix.de>; Sascha Hauer <kernel@...gutronix.de>; Fabio
> Estevam <fabio.estevam@....com>; Rob Herring <robh+dt@...nel.org>;
> Mark Rutland <mark.rutland@....com>; dl-linux-imx <linux-imx@....com>;
> moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
> <linux-arm-kernel@...ts.infradead.org>; open list:OPEN FIRMWARE AND
> FLATTENED DEVICE TREE BINDINGS <devicetree@...r.kernel.org>;
> linux-kernel <linux-kernel@...r.kernel.org>
> Subject: Re: [PATCH] ARM: dts: make pfuze switch always-on for imx platforms
> 
> On Tue, Jun 26, 2018 at 3:08 AM, Anson Huang <Anson.Huang@....com>
> wrote:
> > commit (5fe156f regulator: pfuze100: add enable/disable for switch)
> > will cause those unreferenced switches being
> 
> Nit: The proper way to reference a commit is:
> 
> commit 5fe156f1cab4 ("regulator: pfuze100: add enable/disable for switch")
> 
> 12 char for the commit ID and the commit name inside (" ").
> 
> > turned off if "regulator-always-on" is NOT present, as pfuze switches
> > are normally used by critical modules which must be always ON or
> > shared by many peripherals which do NOT implement power domain
> > control, so just make sure all switches always ON to avoid any system
> > issue caused by unexpectedly turning off switches.
> >
> > Signed-off-by: Anson Huang <Anson.Huang@....com>
> 
> Reviewed-by: Fabio Estevam <fabio.estevam@....com>

Thanks, will improve it and also the other patch for imx6sll.

Anson.