linux-kernel - Re: [PATCH V7 01/24] dm: use bio_split() when splitting out the already processed bio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180627131711.GA11531@redhat.com>
Date:   Wed, 27 Jun 2018 09:17:11 -0400
From:   Mike Snitzer <snitzer@...hat.com>
To:     Ming Lei <ming.lei@...hat.com>
Cc:     Jens Axboe <axboe@...com>, Christoph Hellwig <hch@...radead.org>,
        Kent Overstreet <kent.overstreet@...il.com>,
        David Sterba <dsterba@...e.cz>,
        Huang Ying <ying.huang@...el.com>,
        linux-kernel@...r.kernel.org, linux-block@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
        Theodore Ts'o <tytso@....edu>,
        "Darrick J . Wong" <darrick.wong@...cle.com>,
        Coly Li <colyli@...e.de>, Filipe Manana <fdmanana@...il.com>,
        Randy Dunlap <rdunlap@...radead.org>, stable@...r.kernel.org
Subject: Re: [PATCH V7 01/24] dm: use bio_split() when splitting out the
 already processed bio

On Wed, Jun 27 2018 at  8:45am -0400,
Ming Lei <ming.lei@...hat.com> wrote:

> From: Mike Snitzer <snitzer@...hat.com>
> 
> Use of bio_clone_bioset() is inefficient if there is no need to clone
> the original bio's bio_vec array.  Best to use the bio_clone_fast()
> variant.  Also, just using bio_advance() is only part of what is needed
> to properly setup the clone -- it doesn't account for the various
> bio_integrity() related work that also needs to be performed (see
> bio_split).
> 
> Address both of these issues by switching from bio_clone_bioset() to
> bio_split().
> 
> Fixes: 18a25da8 ("dm: ensure bio submission follows a depth-first tree walk")
> Cc: stable@...r.kernel.org
> Reported-by: Christoph Hellwig <hch@....de>
> Reviewed-by: NeilBrown <neilb@...e.com>
> Reviewed-by: Ming Lei <ming.lei@...hat.com>
> Signed-off-by: Mike Snitzer <snitzer@...hat.com>

FYI, I'll be sending this to Linus tomorrow.

Mike