linux-kernel - Re: [PATCH] userns: move user access out of the mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180627163209.GA23160@mail.hallyn.com>
Date:   Wed, 27 Jun 2018 11:32:09 -0500
From:   "Serge E. Hallyn" <serge@...lyn.com>
To:     Christian Brauner <christian.brauner@...onical.com>
Cc:     Jann Horn <jannh@...gle.com>,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        kernel list <linux-kernel@...r.kernel.org>,
        security@...nel.org, Andy Lutomirski <luto@...capital.net>,
        Kees Cook <keescook@...omium.org>,
        "Serge E. Hallyn" <serge@...lyn.com>
Subject: Re: [PATCH] userns: move user access out of the mutex

Quoting Christian Brauner (christian.brauner@...onical.com):
> On Tue, Jun 26, 2018 at 04:06:45PM +0200, Jann Horn wrote:
> > On Tue, Jun 26, 2018 at 3:08 PM Christian Brauner
> > <christian.brauner@...onical.com> wrote:
> > >
> > > On Mon, Jun 25, 2018 at 06:34:19PM +0200, Jann Horn wrote:
> > > > The old code would hold the userns_state_mutex indefinitely if
> > > > memdup_user_nul stalled due to e.g. a userfault region. Prevent that by
> > > > moving the memdup_user_nul in front of the mutex_lock().
> > > >
> > > > Note: This changes the error precedence of invalid buf/count/*ppos vs
> > > > map already written / capabilities missing.
> > > >
> > > > Fixes: 22d917d80e84 ("userns: Rework the user_namespace adding uid/gid...")
> > > > Cc: stable@...r.kernel.org
> > > > Signed-off-by: Jann Horn <jannh@...gle.com>
> 
> Acked-by: Christian Brauner <christian@...uner.io>

Acked-by: Serge Hallyn <serge@...lyn.com>

thanks.

-serge