linux-kernel - RE: [PATCH v7] tpm: separate cmd_ready/go_idle from runtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B9D956753@hasmsx108.ger.corp.intel.com>
Date:   Wed, 27 Jun 2018 21:13:40 +0000
From:   "Winkler, Tomas" <tomas.winkler@...el.com>
To:     Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Alan Cox <alan@...ux.intel.com>,
        "Shevchenko, Andriy" <andriy.shevchenko@...el.com>,
        "Struk, Tadeusz" <tadeusz.struk@...el.com>
CC:     "Usyskin, Alexander" <alexander.usyskin@...el.com>,
        "linux-integrity@...r.kernel.org" <linux-integrity@...r.kernel.org>,
        "linux-security-module@...r.kernel.org" 
        <linux-security-module@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: RE: [PATCH v7] tpm: separate cmd_ready/go_idle from runtime_pm



> On Tue, 2018-06-26 at 21:15 +0000, Winkler, Tomas wrote:
> > > Right now if I really put head into this I can understand the logic
> > > but it is a complete mess.
> >
> > I think what is the mess is that we have a recursive call to
> > tpm_transmit topped with retries.  All other mess is just the result of that.
> >
> > > I will forgot the dependencies between flags within few weeks.
> >
> > Hope the reasons are well documented both in code and the commit
> > message, if not let's address that. We really cannot depend on one's
> memory.
> > It's not like I'm not striving for simplest possible code.
> >
> > > A fixed requirement (so that you know) is that they must be
> > > independent.
> >
> > The flags (hope this what you referring here to) are not independent
> > and weren't before, (RAW cannot be called alone as you will have
> > double locking) putting them under one name just should make it clear.
> > I beg you to go over the  code one more time, don't get stuck with
> > flags names, maybe you even discover some real issue.
> >
> > Thanks
> > Tomas
> 
> You should then find a solution where you can remove
> TPM_TRANSMIT_RAW completely and make it as a separate commit, not
> part of the bug fix.
> This is not in a shape that I would dare to put this in a pull request.

Very well, I will remove the NESTED flag.  though I have feeling you are shooting from the hip you didn't really read the code. 
Please there anyone who can review the code?
Tomas