linux-kernel - Re: test_syscall_vdso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALCETrVc5f9VMQtZ-_GeGzhmttXnFMjipK6ER59Q0LbY076N+w@mail.gmail.com>
Date:   Tue, 26 Jun 2018 22:13:26 -0700
From:   Andy Lutomirski <luto@...nel.org>
To:     zhijianx.li@...el.com, Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...nel.org>
Cc:     Andrew Lutomirski <luto@...nel.org>,
        Denys Vlasenko <dvlasenk@...hat.com>,
        LKML <linux-kernel@...r.kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@...r.kernel.org>,
        "Li, Philip" <philip.li@...el.com>,
        kernel test robot <xiaolong.ye@...el.com>
Subject: Re: test_syscall_vdso_32 [FAIL]

On Mon, Jun 25, 2018 at 6:23 PM Li Zhijian <zhijianx.li@...el.com> wrote:
>
> On 6/25/2018 11:40 PM, Andy Lutomirski wrote:
> > On Mon, Jun 25, 2018 at 1:41 AM Li Zhijian <zhijianx.li@...el.com> wrote:
> >> Hi
> >>
> >> Intel 0Day noticed that test_syscall_vdso_32 failed since 8bb2610bc4967f19672444a7b0407367f1540028(x86/entry/64/compat: Preserve r8-r11 in int $0x80)
> >>

[snipped]

Indeed.

Hi Thomas-

Something went wrong when you applied the patch mentioned above.  The
original patch is here:

https://lore.kernel.org/lkml/d4c4d9985fbe64f8c9e19291886453914b48caee.1523975710.git.luto@kernel.org/

but somehow it got applied with huge offset -- the same exact change
was made, but it was made to the entirely wrong function!  I'm a
little nervous about sending a fixup patch because there are three
copies of that code in the file, and I don't want to just move the
problem around.  What's the right thing to do here?

Clearly this needs to get fixed somehow, and the fix should go to -stable.

--Andy