linux-kernel - Re: [PATCH net-next v2 1/3] net: phy: xgmiitorgmii: Check phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180628.161235.277685925315349662.davem@davemloft.net>
Date:   Thu, 28 Jun 2018 16:12:35 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     brandon.maier@...kwellcollins.com
Cc:     netdev@...r.kernel.org, andrew@...n.ch, f.fainelli@...il.com,
        michal.simek@...inx.com, clayton.shotwell@...kwellcollins.com,
        kristopher.cory@...kwellcollins.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2 1/3] net: phy: xgmiitorgmii: Check
 phy_driver ready before accessing

From: Brandon Maier <brandon.maier@...kwellcollins.com>
Date: Tue, 26 Jun 2018 12:50:48 -0500

> Since a phy_device is added to the global mdio_bus list during
> phy_device_register(), but a phy_device's phy_driver doesn't get
> attached until phy_probe(). It's possible of_phy_find_device() in
> xgmiitorgmii will return a valid phy with a NULL phy_driver. Leading to
> a NULL pointer access during the memcpy().
> 
> Fixes this Oops:
 ...
> Signed-off-by: Brandon Maier <brandon.maier@...kwellcollins.com>

Applied.