linux-kernel - Re: [PATCH] arm64: remove no-op -p linker flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180628093928.GB10751@arm.com>
Date:   Thu, 28 Jun 2018 10:39:29 +0100
From:   Will Deacon <will.deacon@....com>
To:     Greg Hackmann <ghackmann@...roid.com>
Cc:     Catalin Marinas <catalin.marinas@....com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        ndesaulniers@...gle.com, mka@...omium.org,
        Greg Hackmann <ghackmann@...gle.com>
Subject: Re: [PATCH] arm64: remove no-op -p linker flag

On Wed, Jun 27, 2018 at 12:46:14PM -0700, Greg Hackmann wrote:
> Linking the ARM64 defconfig kernel with LLVM lld fails with the error:
> 
>   ld.lld: error: unknown argument: -p
>   Makefile:1015: recipe for target 'vmlinux' failed
> 
> Without this flag, the ARM64 defconfig kernel successfully links with
> lld and boots on Dragonboard 410c.
> 
> After digging through binutils source and changelogs, it turns out that
> -p is only relevant to ancient binutils installations targeting 32-bit
> ARM.  binutils accepts -p for AArch64 too, but it's always been
> undocumented and silently ignored.  A comment in
> ld/emultempl/aarch64elf.em explains that it's "Only here for backwards
> compatibility".
> 
> Since this flag is a no-op on ARM64, we can safely drop it.

Makes sense:

Acked-by: Will Deacon <will.deacon@....com>

Will