linux-kernel - Re: [PATCH 0/7] Fix issues in UAC2 gadget driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180628113930.GA8176@vmlxhi-102.adit-jv.com>
Date:   Thu, 28 Jun 2018 13:39:30 +0200
From:   Eugeniu Rosca <erosca@...adit-jv.com>
To:     Felipe Balbi <felipe.balbi@...ux.intel.com>
CC:     Andrzej Pietrasiewicz <andrzej.p@...sung.com>,
        Daniel Mack <zonque@...il.com>,
        Felipe Balbi <balbi@...nel.org>,
        Ruslan Bilovol <ruslan.bilovol@...il.com>,
        Jassi Brar <jaswinder.singh@...aro.org>,
        Robert Baldyga <r.baldyga@...sung.com>,
        Peter Chen <peter.chen@....com>,
        Christoph Hellwig <hch@....de>,
        Eugeniu Rosca <rosca.eugeniu@...il.com>,
        Eugeniu Rosca <erosca@...adit-jv.com>,
        Vladimir Zapolskiy <vladimir_zapolskiy@...tor.com>,
        Joshua Frkuska <joshua_frkuska@...tor.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/7] Fix issues in UAC2 gadget driver

Hi Felipe,

Friendly reminder. May I have some feedback on the shared USB fixes?

Best regards,
Eugeniu.

On Thu, Jun 21, 2018 at 05:22:45PM +0200, Eugeniu Rosca wrote:
> Hello Felipe and linux-usb community,
> 
> This is a collection of UAC fixes, some of which have been written back
> in 2016 on top of v3.14. v4.13-rc1 commit eb9fecb9e69b ("usb: gadget:
> f_uac2: split out audio core") made forward-porting of these patches to
> recent kernels quite painful and time-consuming, so we decided to
> re-base them against v4.18-rc1, re-test and share them with community.
> 
> These changes have already undergone internal review, which includes:
> * static analysis:
>  - checkpatch --strict, cppcheck, smatch, sparse, coccicheck, make W=1
> * dynamic testing:
>  - Audio playback on host side and recording on gadget side, where the
>    latter is RCAR Gen3 Salvator-X arm64 target and the former is a
>    Ubuntu PC or an appropriate USB port on the same RCAR target.
>    The kernel was compiled with and w/o KA/UB sanitizers.
> 
> The "older" patches actually live in real Customer products.
> 
> Thank you in advance for any feedback/review comments.
> 
> Best regards,
> Eugeniu.
> 
> Contributors (auto-generated by git)
> 
> Andreas Pape (1):
>   usb: gadget: f_uac2: disable IN/OUT ep if unused
> 
> Eugeniu Rosca (2):
>   usb: gadget: f_uac2: fix error handling in afunc_bind (again)
>   usb: gadget: u_audio: fix pcm/card naming in g_audio_setup()
> 
> Joshua Frkuska (1):
>   usb: gadget: u_audio: update hw_ptr in iso_complete after data copied
> 
> Vladimir Zapolskiy (3):
>   usb: gadget: u_audio: remove caching of stream buffer parameters
>   usb: gadget: u_audio: remove cached period bytes value
>   usb: gadget: u_audio: protect stream runtime fields with stream
>     spinlock
> 
>  drivers/usb/gadget/function/f_uac2.c  | 216 ++++++++++++++++++++------
>  drivers/usb/gadget/function/u_audio.c |  88 ++++-------
>  2 files changed, 205 insertions(+), 99 deletions(-)
> 
> -- 
> 2.17.0
>