linux-kernel - RE: [[LINUX PATCH v10] 2/4] memory: pl353: Add driver for arm pl353 static memory controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MWHPR02MB2623C017D4A632F7A25FFD27AF4F0@MWHPR02MB2623.namprd02.prod.outlook.com>
Date:   Thu, 28 Jun 2018 12:10:30 +0000
From:   Naga Sureshkumar Relli <nagasure@...inx.com>
To:     Linus Walleij <linus.walleij@...aro.org>
CC:     Boris Brezillon <boris.brezillon@...tlin.com>,
        Richard Weinberger <richard@....at>,
        David Woodhouse <dwmw2@...radead.org>,
        Brian Norris <computersforpeace@...il.com>,
        Mark Vasut <marek.vasut@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Markus Mayer <mmayer@...adcom.com>,
        Roger Quadros <rogerq@...com>,
        Ladislav Michl <ladis@...ux-mips.org>,
        "ada@...rsis.com" <ada@...rsis.com>,
        "honghui.zhang@...iatek.com" <honghui.zhang@...iatek.com>,
        Miquèl Raynal <miquel.raynal@...tlin.com>,
        "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "nagasureshkumarrelli@...il.com" <nagasureshkumarrelli@...il.com>,
        Michal Simek <michals@...inx.com>
Subject: RE: [[LINUX PATCH v10] 2/4] memory: pl353: Add driver for arm pl353
 static memory controller

Hi Linux,

Thanks for the review.

> -----Original Message-----
> From: Linus Walleij [mailto:linus.walleij@...aro.org]
> Sent: Thursday, June 28, 2018 12:19 PM
> To: Naga Sureshkumar Relli <nagasure@...inx.com>
> Cc: Boris Brezillon <boris.brezillon@...tlin.com>; Richard Weinberger <richard@....at>;
> David Woodhouse <dwmw2@...radead.org>; Brian Norris
> <computersforpeace@...il.com>; Mark Vasut <marek.vasut@...il.com>; Florian Fainelli
> <f.fainelli@...il.com>; Markus Mayer <mmayer@...adcom.com>; Roger Quadros
> <rogerq@...com>; Ladislav Michl <ladis@...ux-mips.org>; ada@...rsis.com;
> honghui.zhang@...iatek.com; Miquèl Raynal <miquel.raynal@...tlin.com>; linux-
> mtd@...ts.infradead.org; linux-kernel@...r.kernel.org; nagasureshkumarrelli@...il.com;
> Michal Simek <michals@...inx.com>
> Subject: Re: [[LINUX PATCH v10] 2/4] memory: pl353: Add driver for arm pl353 static
> memory controller
> 
> On Thu, Jun 21, 2018 at 8:43 AM Naga Sureshkumar Relli
> <naga.sureshkumar.relli@...inx.com> wrote:
> 
> > Add driver for arm pl353 static memory controller. This controller is
> > used in Xilinx Zynq SoC for interfacing the NAND and NOR/SRAM memory devices.
> >
> > Signed-off-by: Naga Sureshkumar Relli
> > <naga.sureshkumar.relli@...inx.com>
> 
> (...)
> 
> > +config PL353_SMC
> > +       tristate "ARM PL35X Static Memory Controller(SMC) driver"
> > +       default y
> > +       depends on ARM
> > +       depends on ARCH_ZYNQ
> 
> depends on ARM_AMBA
Ok. I will add it next version.
> 
> > +#include <linux/platform_device.h>
> 
> This is a PrimeCell with the ARM primecell ID registers specified, so it should not use
> platform device.
Thanks for pointing these drivers. Let me go through these.

> 
> Use <linux/amba/bus.h>
> 
> It further needs to match on these magic values (found in
> 0xfe0 etc) and use the name "apb_pclk" for the peripheral
> (silicon) clock.
> 
> See examples such as:
> drivers/mmc/host/mmci.c
> drivers/tty/serial/amba-pl011.c
> drivers/video/fbdev/amba-clcd.c
> drivers/hwtracing/coresight/*
> etc for examples.
> 
> Also see and reference the special PrimeCell DT bindings:
> Documentation/devicetree/bindings/arm/primecell.txt
Ok. I will go through these bindings once.
> 
> Yours,
> Linus Walleij

Thank for your review.

Regards,
Naga Sureshkumar Relli.