linux-kernel - RE: [PATCH v7] tpm: separate cmd_ready/go_idle from runtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B9D95729D@hasmsx108.ger.corp.intel.com>
Date:   Thu, 28 Jun 2018 15:02:39 +0000
From:   "Winkler, Tomas" <tomas.winkler@...el.com>
To:     Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Alan Cox <alan@...ux.intel.com>,
        "Shevchenko, Andriy" <andriy.shevchenko@...el.com>,
        "Struk, Tadeusz" <tadeusz.struk@...el.com>
CC:     "Usyskin, Alexander" <alexander.usyskin@...el.com>,
        "linux-integrity@...r.kernel.org" <linux-integrity@...r.kernel.org>,
        "linux-security-module@...r.kernel.org" 
        <linux-security-module@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: RE: [PATCH v7] tpm: separate cmd_ready/go_idle from runtime_pm



> 
> On Wed, 2018-06-27 at 21:13 +0000, Winkler, Tomas wrote:
> > Very well, I will remove the NESTED flag.  though I have feeling you
> > are shooting from the hip you didn't really read the code.
> > Please there anyone who can review the code?
> 
> Asking to change a minor thing in a patch does not really fit into that profile.
> I've even tried the patch a few times in it seems to work just fine. You are
> making a big deal out of nothing.

I cannot agree with you but I will submit a new patch, I got tired to explaining it.  
Need to progress with it finally, tpm is failing to probe on those platforms since 4.16.

Thanks
Tomas.