Message-ID: <20180628111623.3807fe9b@naga.suse.cz>
Date:   Thu, 28 Jun 2018 11:16:23 +0200
From:   Michal Suchánek <msuchanek@...e.de>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Takashi Iwai <tiwai@...e.de>, Andreas Schwab <schwab@...e.de>,
        Michal Kubecek <mkubecek@...e.cz>,
        Michal Marek <michal.lkml@...kovi.net>,
        Jonathan Corbet <corbet@....net>,
        Yoshinori Sato <ysato@...rs.sourceforge.jp>,
        Rich Felker <dalias@...c.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jeff Dike <jdike@...toit.com>,
        Richard Weinberger <richard@....at>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>, X86 ML <x86@...nel.org>,
        Kees Cook <keescook@...omium.org>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Ulf Magnusson <ulfalizer@...il.com>,
        Jeff Mahoney <jeffm@...e.com>,
        "Peter Zijlstra," <peterz@...radead.org>,
        Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
        Frederic Weisbecker <frederic@...nel.org>,
        Randy Dunlap <rdunlap@...radead.org>,
        Dominik Brodowski <linux@...inikbrodowski.net>,
        Nicholas Piggin <npiggin@...il.com>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        "open list:DOCUMENTATION" <linux-doc@...r.kernel.org>,
        Linux-sh list <linux-sh@...r.kernel.org>,
        sparclinux <sparclinux@...r.kernel.org>,
        linux-um@...ts.infradead.org
Subject: Re: due to kconfig changes kernel config file is no longer
 sufficient for configuring the kernel

On Wed, 27 Jun 2018 23:07:21 +0900
Masahiro Yamada <yamada.masahiro@...ionext.com> wrote:

> Hi.
> 
> 
> 2018-06-27 21:37 GMT+09:00 Michal Suchánek <msuchanek@...e.de>:
> > Hello,
> >
> > in the x86 Kconfig we have this:
> >
> > # Select 32 or 64 bit
> > config 64BIT
> >         bool "64-bit kernel" if "$(ARCH)" = "x86"
> >         default "$(ARCH)" != "i386"
> >         ---help---
> >           Say yes to build a 64-bit kernel - formerly known as
> > x86_64 Say no to build a 32-bit kernel - formerly known as i386
> >
> > Since commit 104daea149c4 ("kconfig: reference environment variables
> > directly and remove 'option env='") the value of ARCH is not saved
> > in the kernel config.  
> 
> I think this commit is unrelated.  It was just a syntax change.

This does not look like syntax only change to me:

diff --git a/init/Kconfig b/init/Kconfig
index 15aae32e0719..1217fc62ca61 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -1,20 +1,12 @@
-config ARCH
-       string
-       option env="ARCH"
-
-config KERNELVERSION
-       string
-       option env="KERNELVERSION"
-

> 
> Unless I am missing something,
> we have never saved ARCH in the .config in the past.

There was a config symbol defined for it before the commit removed it.

> 
> 
> > Since commit f467c5640c29 ("kconfig: only write '#
> > CONFIG_FOO is not set' for visible symbols") the value of 64BIT is
> > not saved if the ARCH is set i386 or x86_64 because the symbol is
> > not visible.  
> 
> This is correct.
> 
> It was discussed a few weeks ago.
> 
> https://lkml.org/lkml/2018/6/5/847
> 
> 
> > There is a number of ways to hack this particular case to work.
> >
> > However, there is a more general problem with this. Some config
> > options may depend on the environment, may not be saved, and the
> > environment is not saved either.  
> 
> Which environment variables in particular are in your mind?

Any that is used in Kconfig.

> 
> As for ARCH, you need to pass the same ARCH as you used for building
> the kernel. (For native building, you do not have to pass ARCH
> explicitly, though.)

Except if you do pass it to make config you may need to pass it to to
make later as well.

> 
> As for CC, HOSTCC, etc.
> yes, these are new 'unsaved' environments.
> 
> CONFIG options now depend on the compiler.
> This is the concept suggested by Linus Torvalds.
> 
> 
> > So in the end all the infrastructure with symlinks
> > from module directory pointing to the kernel source and object
> > directory is useless. To interpret the config stored there you need
> > the environment and that is not saved anywhere. So if you try to
> > build out-of-tree module it might end up reconfiguring your kernel
> > and producing useless modules.  
> 
> No. out-of-tree module building never ever re-configures the kernel.

It does implicitly because the config values depend on environment that
is not saved and the values themselves are not saved either. If that
happens to expose a new variable it is even explicitly reconfigured.

> 
> out-of-tree modules are built with exactly the same configuration
> as used for the kernel.

It is not true. And that is the problem. You need the config file and
dump of the environment passed to the make command at configuration
time to get the exact same configuration. The environment is not saved
anywhere, though.

Thanks

Michal

Powered by blists - more mailing lists