linux-kernel - Re: [PATCH 1/3] arm64: dts: qcom: sdm845: Add thermal-zones node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=UPCgEvN1F5jFhLxq=KrH2_BwEG=ZRX3npy_EPLZ_V0hA@mail.gmail.com>
Date:   Thu, 28 Jun 2018 15:52:57 -0700
From:   Doug Anderson <dianders@...omium.org>
To:     Matthias Kaehlcke <mka@...omium.org>
Cc:     Andy Gross <andy.gross@...aro.org>,
        David Brown <david.brown@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>,
        "open list:ARM/QUALCOMM SUPPORT" <linux-soc@...r.kernel.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        David Collins <collinsd@...eaurora.org>,
        Stephen Boyd <sboyd@...nel.org>
Subject: Re: [PATCH 1/3] arm64: dts: qcom: sdm845: Add thermal-zones node

Hi,

On Thu, Jun 28, 2018 at 2:09 PM, Matthias Kaehlcke <mka@...omium.org> wrote:
> The node is empty for now. It is needed to allow other DT snippets
> to add thermal zone entries.
>
> Signed-off-by: Matthias Kaehlcke <mka@...omium.org>
> ---
> Sorry if you received this twice, lists were missing in cc in the first attempt ...
>
>  arch/arm64/boot/dts/qcom/sdm845.dtsi | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index 00722b533a92..968390fb0933 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -9,6 +9,7 @@
>  #include <dt-bindings/clock/qcom,rpmh.h>
>  #include <dt-bindings/interrupt-controller/arm-gic.h>
>  #include <dt-bindings/soc/qcom,rpmh-rsc.h>
> +#include <dt-bindings/thermal/thermal.h>
>
>  / {
>         interrupt-parent = <&intc>;
> @@ -1087,4 +1088,7 @@
>                         };
>                 };
>         };
> +
> +       thermal_zones: thermal-zones {
> +       };

Others can feel free to disagree, but IMO ${SUBJECT} patch is not
needed.  Instead patch #3 in your series should just define a
"thermal-zones" node at the root level.  The "thermal-zones" node is a
well-defined node with a well-defined node name and location (see the
"thermal.txt" binding).  If the SoC has a "thermal-zones" node and so
does the PMIC then they'll just be merged.


-Doug