linux-kernel - Re: [PATCH v2] regulator: arizona-ldo1: Use correct device to get enable GPIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdbT_3BrJxAs=giq=FDZWPL_471ZZWYxQP8RV9COM_XgJQ@mail.gmail.com>
Date:   Fri, 29 Jun 2018 10:05:19 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Charles Keepax <ckeepax@...nsource.cirrus.com>
Cc:     Mark Brown <broonie@...nel.org>, hias@...us.com,
        Liam Girdwood <lgirdwood@...il.com>,
        patches@...nsource.cirrus.com,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] regulator: arizona-ldo1: Use correct device to get
 enable GPIO

On Tue, Jun 19, 2018 at 5:10 PM Charles Keepax
<ckeepax@...nsource.cirrus.com> wrote:

> Currently the enable GPIO is being looked up on the regulator
> device itself but that does not have its own DT node, this causes
> the lookup to fail and the regulator not to get its GPIO. The DT
> node is shared across the whole MFD and as such the lookup needs
> to happen on that parent device. Moving the lookup to the parent
> device also means devres can no longer be used as the life time
> would attach to the wrong device.
>
> Additionally, the enable GPIO is active high so we should be passing
> GPIOD_OUT_LOW to ensure the regulator starts in its off state allowing
> the driver to enable it when it is ready.
>
> Fixes: e1739e86f0cb ("regulator: arizona-ldo1: Look up a descriptor and pass to the core")
> Reported-by: Matthias Reichl <hias@...us.com>
> Signed-off-by: Charles Keepax <ckeepax@...nsource.cirrus.com>
> ---
>
> Changes since v1:
>  - Pass GPIOD_OUT_LOW to gpiod_get_optional

Nice, thanks for fixing this!
Sorry for screwing it up :(

I wish I could be more careful, but without access to the
hardware it is sometimes pretty tricky not to break things
by mistake.

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij