linux-kernel - Re: [PATCH] ARM: dts: imx6: correct anatop regulators range

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 29 Jun 2018 10:15:09 +0200
From:   Lucas Stach <l.stach@...gutronix.de>
To:     Anson Huang <Anson.Huang@....com>, shawnguo@...nel.org,
        s.hauer@...gutronix.de, kernel@...gutronix.de,
        fabio.estevam@....com, robh+dt@...nel.org, mark.rutland@....com,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Linux-imx@....com
Subject: Re: [PATCH] ARM: dts: imx6: correct anatop regulators range

Am Freitag, den 29.06.2018, 15:54 +0800 schrieb Anson Huang:
> Correct some i.MX6 SoCs anatop regulators range
> according to reference manual.
> 
> Signed-off-by: Anson Huang <Anson.Huang@....com>

NACK.

This is wrong. While the regulator supports this range, the SoC
doesn't. The current settings are derived from the allowed operating
ranges of the SoC (at least for the MX6QDL), which is in accordance
with how regulator constraints in DT are meant to be used.

Regards,
Lucas

> ---
>  arch/arm/boot/dts/imx6qdl.dtsi | 12 ++++++------
>  arch/arm/boot/dts/imx6sl.dtsi  |  4 ++--
>  arch/arm/boot/dts/imx6sx.dtsi  |  4 ++--
>  3 files changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
> index 911141e..d9f98dd 100644
> --- a/arch/arm/boot/dts/imx6qdl.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl.dtsi
> @@ -689,8 +689,8 @@
> >  				regulator-1p1 {
> >  					compatible = "fsl,anatop-regulator";
> >  					regulator-name = "vdd1p1";
> > -					regulator-min-microvolt = <1000000>;
> > -					regulator-max-microvolt = <1200000>;
> > +					regulator-min-microvolt = <800000>;
> > +					regulator-max-microvolt = <1375000>;
> >  					regulator-always-on;
> >  					anatop-reg-offset = <0x110>;
> >  					anatop-vol-bit-shift = <8>;
> @@ -704,8 +704,8 @@
> >  				regulator-3p0 {
> >  					compatible = "fsl,anatop-regulator";
> >  					regulator-name = "vdd3p0";
> > -					regulator-min-microvolt = <2800000>;
> > -					regulator-max-microvolt = <3150000>;
> > +					regulator-min-microvolt = <2625000>;
> > +					regulator-max-microvolt = <3400000>;
> >  					regulator-always-on;
> >  					anatop-reg-offset = <0x120>;
> >  					anatop-vol-bit-shift = <8>;
> @@ -719,8 +719,8 @@
> >  				regulator-2p5 {
> >  					compatible = "fsl,anatop-regulator";
> >  					regulator-name = "vdd2p5";
> > -					regulator-min-microvolt = <2250000>;
> > -					regulator-max-microvolt = <2750000>;
> > +					regulator-min-microvolt = <2100000>;
> > +					regulator-max-microvolt = <2875000>;
> >  					regulator-always-on;
> >  					anatop-reg-offset = <0x130>;
> >  					anatop-vol-bit-shift = <8>;
> diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi
> index 81f48116..3d7931b 100644
> --- a/arch/arm/boot/dts/imx6sl.dtsi
> +++ b/arch/arm/boot/dts/imx6sl.dtsi
> @@ -539,8 +539,8 @@
> >  				regulator-3p0 {
> >  					compatible = "fsl,anatop-regulator";
> >  					regulator-name = "vdd3p0";
> > -					regulator-min-microvolt = <2800000>;
> > -					regulator-max-microvolt = <3150000>;
> > +					regulator-min-microvolt = <2625000>;
> > +					regulator-max-microvolt = <3400000>;
> >  					regulator-always-on;
> >  					anatop-reg-offset = <0x120>;
> >  					anatop-vol-bit-shift = <8>;
> diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
> index 7130ab8..f26f611 100644
> --- a/arch/arm/boot/dts/imx6sx.dtsi
> +++ b/arch/arm/boot/dts/imx6sx.dtsi
> @@ -607,8 +607,8 @@
> >  				regulator-3p0 {
> >  					compatible = "fsl,anatop-regulator";
> >  					regulator-name = "vdd3p0";
> > -					regulator-min-microvolt = <2800000>;
> > -					regulator-max-microvolt = <3150000>;
> > +					regulator-min-microvolt = <2625000>;
> > +					regulator-max-microvolt = <3400000>;
> >  					regulator-always-on;
> >  					anatop-reg-offset = <0x120>;
> >  					anatop-vol-bit-shift = <8>;