linux-kernel - Re: small dmesg regression in kernel 4.17.3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vcp=uNrQDxGFgPjji4HxEQDR+DGeK5UgtG46ZYiV0Ag5Q@mail.gmail.com>
Date:   Fri, 29 Jun 2018 13:43:13 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     "Schmauss, Erik" <erik.schmauss@...el.com>
Cc:     Toralf Förster <toralf.foerster@....de>,
        "Moore, Robert" <robert.moore@...el.com>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: small dmesg regression in kernel 4.17.3

On Fri, Jun 29, 2018 at 1:13 AM, Schmauss, Erik <erik.schmauss@...el.com> wrote:
>> On Tue, Jun 26, 2018 at 8:57 PM, Toralf Förster <toralf.foerster@....de>
>> wrote:
>> > The attached dmesg contains non printable chars 0x01 33 around "ACPI
>> > BIOS Error (bug): Could not resolve" which is a new issue compared to
>> > the dmesg of 4.17.2
>> >
>> > System is a stable hardened Gentoo Linux at a ThinkPad T440s.
>>
>> I bet the below commit makes this.
>>
>> commit 2e78935d1e27d31955ad2dad4abe6c453cf669fd
>> Author: Erik Schmauss <erik.schmauss@...el.com>
>> Date:   Fri Jun 1 12:06:43 2018 -0700
>>
>>    ACPICA: AML parser: attempt to continue loading table after error
>>
>>
> Hi Andy,
>
>> So, it does add leading '\n' which flushes buffers followed by printing the
>> message you see. But, I'm guessing now, kernel adds a default level since it's
>> going to dmesg which you can see as unprintable symbols.
>
> What do you mean by a default level?

I can't find fast the better example, though if you look at  printk_get_level()
https://elixir.bootlin.com/linux/latest/source/include/linux/printk.h#L16

it will shed a light on a format. Thus, 0x01 0x33 means start of the
kernel error message (error is a level).

Kernel messaging protocol is defined in
https://elixir.bootlin.com/linux/latest/source/include/linux/kern_levels.h

This is my understanding on what's going on (I might be mistaken).

-- 
With Best Regards,
Andy Shevchenko