linux-kernel - Re: [PATCH v3] lightnvm: pblk: expose generic disk name on pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <13BD1F74-4DBE-44BA-A774-4844E2886F73@cnexlabs.com>
Date:   Fri, 29 Jun 2018 11:56:24 +0000
From:   Javier Gonzalez <javier@...xlabs.com>
To:     Matias Bjørling <mb@...htnvm.io>
CC:     "Konopko, Igor J" <igor.j.konopko@...el.com>,
        "marcin.dziegielewski@...el.com" <marcin.dziegielewski@...el.com>,
        Hans Holmberg <hans.holmberg@...xlabs.com>,
        Heiner Litz <hlitz@...c.edu>,
        Young Tack Tack Jin <youngtack.jin@...cuitblvd.com>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] lightnvm: pblk: expose generic disk name on pr_* msgs

> On 29 Jun 2018, at 13.45, Matias Bjørling <mb@...htnvm.io> wrote:
> 
> The error messages in pblk does not say which pblk instance that
> a message occurred from. Update each error message to reflect the
> instance it belongs to, and also prefix it with pblk, so we know
> the message comes from the pblk module.
> 
> Signed-off-by: Matias Bjørling <mb@...htnvm.io>
> 
> ---
> 
> v3:
>  - Missing kfree's when spec not supported.
> v2:
>  - Forgot to test with NVM_PBLK_DEBUG on. Fixed up the broken code.
> ---
> drivers/lightnvm/pblk-core.c     | 51 ++++++++++++-------------
> drivers/lightnvm/pblk-gc.c       | 32 ++++++++--------
> drivers/lightnvm/pblk-init.c     | 80 ++++++++++++++++++++--------------------
> drivers/lightnvm/pblk-rb.c       |  8 ++--
> drivers/lightnvm/pblk-read.c     | 25 +++++++------
> drivers/lightnvm/pblk-recovery.c | 44 +++++++++++-----------
> drivers/lightnvm/pblk-sysfs.c    |  5 +--
> drivers/lightnvm/pblk-write.c    | 21 ++++++-----
> drivers/lightnvm/pblk.h          | 29 ++++++++++-----
> 9 files changed, 155 insertions(+), 140 deletions(-)
> 

Looks good to me.

Thanks!

Reviewed-by: Javier González <javier@...xlabs.com>


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)