linux-kernel - Re: [PATCH] drm: Use kvzalloc for allocating blob property memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 29 Jun 2018 18:27:28 +0200
From:   Michel Dänzer <michel@...nzer.net>
To:     Ville Syrjälä <ville.syrjala@...ux.intel.com>
Cc:     David Airlie <airlied@...ux.ie>, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] drm: Use kvzalloc for allocating blob property memory

On 2018-06-29 06:12 PM, Ville Syrjälä wrote:
> On Fri, Jun 29, 2018 at 04:27:10PM +0200, Michel Dänzer wrote:
>> From: Michel Dänzer <michel.daenzer@....com>
>>
>> The property size may be controlled by userspace, can be large (I've
>> seen failure with order 4, i.e. 16 pages / 64 KB) and doesn't need to be
>> physically contiguous.
> 
> I wonder if we should enforce some kind of reasonable limit
> on the blob size. Looks like we allow anything up to
> ULONG_MAX currently. We can't tell at createblob time how
> the thing is going to be used, so can't have any kind
> of property specific limit unfortunately.

The failure I was seeing was for a gamma LUT, so a size limit alone
cannot solve the issue.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer