linux-kernel - Re: [PATCH v2 3/4] RISC-V: Add definiion of extract symbol's index and type for 32-bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+ZOyahLiGS-7DQO8ncJ_=w-Mkav33FBBOC9-K08XSyhPgjtGg@mail.gmail.com>
Date:   Sat, 30 Jun 2018 00:53:49 +0800
From:   Zong Li <zongbox@...il.com>
To:     hch@...radead.org
Cc:     Zong Li <zong@...estech.com>, Palmer Dabbelt <palmer@...ive.com>,
        linux-riscv@...ts.infradead.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        greentime@...estech.com
Subject: Re: [PATCH v2 3/4] RISC-V: Add definiion of extract symbol's index
 and type for 32-bit

Christoph Hellwig <hch@...radead.org> 於 2018年6月29日 週五 下午3:12寫道：
>
> On Mon, Jun 25, 2018 at 04:49:39PM +0800, Zong Li wrote:
> > Use generic marco to get the index and type of symbol.
>
> Why do we even need this in a uapi header?  Shouldn't ELF_RISCV_R_SYM
> and ELF_RISCV_R_TYPE move to module.c?  In that case we could just
> use CONFIG_64BIT.

Make sense. I even think the all definitions can be move to include/asm/elf.h.
How do you think about that?