linux-kernel - Re: [PATCH v3 0/4] Add devicetree functionality to w1 busses and ds2760

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <48c3d0fd-7a31-3531-044c-3cbd307771c8@zonque.org>
Date:   Fri, 29 Jun 2018 19:35:13 +0200
From:   Daniel Mack <daniel@...que.org>
To:     zbr@...emap.net, robh+dt@...nel.org, mark.rutland@....com,
        szabolcs.gyurko@....hu
Cc:     sre@...nel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
        robert.jarzmik@...e.fr
Subject: Re: [PATCH v3 0/4] Add devicetree functionality to w1 busses and
 ds2760

On Friday, June 29, 2018 07:31 PM, Daniel Mack wrote:
> This patch set contains four small patches that bring devicetree
> functionality to w1 bus masters and slaves in general. As an example,
> the DS2760 driver is made aware of devicetree nodes as an example.
> Other drivers can easily be ported later.
> 
> W1 masters scan their bus in order to discover slave devices. Once
> one is found, a driver matching the family of the device is instanciated
> which handles it.
> 
> All that's needed for now is a call to of_find_matching_node() when
> a slave device is attached, so the corresponding of_node pointer is
> set.
> 
> The series also contains a patch that merges the w1 slave driver for the
> DS2760 battery monitor into its only user, the ds2760 supply driver.
> The indirection with two drivers never had any benefit, and here is
> a good opportunity to clean this up.
> 
> Patch #1 adds some DT bindings documentation
> Patch #2 adds the call to of_find_matching_node()
> Patch #3 merges the w1 slave and the supply driver for ds2760
> Patch #4 makes the ds2760 supply driver aware of DT environments
> 
> This works fine on a PXA3xx based board with a battery attached to
> the w1-gpio bus master controller.

Sorry, I messed up the patch statistics in the cover letter. Here is the 
correct version:


  .../bindings/power/supply/maxim,ds2760.txt    |  29 ++
  .../devicetree/bindings/w1/w1-gpio.txt        |   6 +
  Documentation/devicetree/bindings/w1/w1.txt   |  18 +
  drivers/power/supply/Kconfig                  |   2 +-
  drivers/power/supply/ds2760_battery.c         | 351 +++++++++++++-----
  drivers/w1/slaves/Kconfig                     |  12 -
  drivers/w1/slaves/Makefile                    |   1 -
  drivers/w1/slaves/w1_ds2760.c                 | 175 ---------
  drivers/w1/slaves/w1_ds2760.h                 |  59 ---
  drivers/w1/w1.c                               |   3 +
  include/linux/w1.h                            |   2 +
  11 files changed, 320 insertions(+), 338 deletions(-)
  create mode 100644 
Documentation/devicetree/bindings/power/supply/maxim,ds2760.txt
  create mode 100644 Documentation/devicetree/bindings/w1/w1.txt
  delete mode 100644 drivers/w1/slaves/w1_ds2760.c
  delete mode 100644 drivers/w1/slaves/w1_ds2760.h