linux-kernel - Re: [patch 1/2] posix-timers: Make forward callback return s64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALAqxLV_qDmWf9MU0hUqqHmPdM7hKmQ4qskfiHGyX9F6JeGvyw@mail.gmail.com>
Date:   Thu, 28 Jun 2018 21:25:21 -0700
From:   John Stultz <john.stultz@...aro.org>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Michael Kerrisk <mtk.manpages@...il.com>,
        air icy <icytxw@...il.com>
Subject: Re: [patch 1/2] posix-timers: Make forward callback return s64

On Tue, Jun 26, 2018 at 6:21 AM, Thomas Gleixner <tglx@...utronix.de> wrote:
> The posix timer ti_overrun handling is broken because the forwarding
> functions can return a huge number of overruns which does not fit in an
> int. As a consequence timer_getoverrun(2) and siginfo::si_overrun can turn
> into random number generators.
>
> As a first step to address that let the timer_forward() callbacks return
> the full 64 bit value.
>
> Cast it to (int) temporarily until k_itimer::ti_overrun is converted to
> 64bit and the conversion to user space visible values is sanitized.
>
> Reported-by: air icy <icytxw@...il.com>
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>

Looks ok, and doesn't trip any regressions in testing so far.

Acked-by: John Stultz <john.stultz@...aro.org>

thanks
-john