linux-kernel - Re: [PATCHv3 2/4] nvme: use hw qid in trace events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180629202307.GA13865@localhost.localdomain>
Date:   Fri, 29 Jun 2018 14:23:07 -0600
From:   Keith Busch <keith.busch@...ux.intel.com>
To:     Keith Busch <keith.busch@...el.com>
Cc:     Johannes Thumshirn <jthumshirn@...e.de>,
        Christoph Hellwig <hch@....de>,
        Sagi Grimberg <sagi@...mberg.me>,
        linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCHv3 2/4] nvme: use hw qid in trace events

On Fri, Jun 29, 2018 at 01:59:58PM -0600, Keith Busch wrote:
> +	    TP_printk("qid=%d, cmdid=%u, nsid=%u, flags=0x%x, meta=0x%llx, cmd=(%s %s)",
> +		      __entry->qid, __entry->nsid, __entry->cid, 

Ugh, the nsid and cid are swapped here, and carried through to the end
of the series. Will need to send a v4.