linux-kernel - Re: [PATCH] net: cleanup gfp mask in alloc_skb_with

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180630.201917.1237479559141460617.davem@davemloft.net>
Date:   Sat, 30 Jun 2018 20:19:17 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     mhocko@...nel.org
Cc:     edumazet@...gle.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, mhocko@...e.com
Subject: Re: [PATCH] net: cleanup gfp mask in alloc_skb_with_frags

From: Michal Hocko <mhocko@...nel.org>
Date: Thu, 28 Jun 2018 17:53:06 +0200

> From: Michal Hocko <mhocko@...e.com>
> 
> alloc_skb_with_frags uses __GFP_NORETRY for non-sleeping allocations
> which is just a noop and a little bit confusing.
> 
> __GFP_NORETRY was added by ed98df3361f0 ("net: use __GFP_NORETRY for
> high order allocations") to prevent from the OOM killer. Yet this was
> not enough because fb05e7a89f50 ("net: don't wait for order-3 page
> allocation") didn't want an excessive reclaim for non-costly orders
> so it made it completely NOWAIT while it preserved __GFP_NORETRY in
> place which is now redundant.
> 
> Drop the pointless __GFP_NORETRY because this function is used as
> copy&paste source for other places.
> 
> Reviewed-by: Eric Dumazet <edumazet@...gle.com>
> Signed-off-by: Michal Hocko <mhocko@...e.com>

Applied.