linux-kernel - Re: [PATCH v7] drivers/staging: Gasket driver framework + Apex driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2d0d235418958e8b60913b1e0d630b8c9213ea5b.camel@perches.com>
Date:   Fri, 29 Jun 2018 20:21:24 -0700
From:   Joe Perches <joe@...ches.com>
To:     Simon Que <sque@...omium.org>, linux-kernel@...r.kernel.org
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Ben Chan <benchan@...omium.org>,
        Chun-Ta Lin <itspeter@...omium.org>,
        Zhongze Hu <frankhu@...omium.org>,
        Randy Dunlap <rdunlap@...radead.org>,
        Rob Springer <rspringer@...gle.com>,
        John Joseph <jnjoseph@...gle.com>
Subject: Re: [PATCH v7] drivers/staging: Gasket driver framework + Apex
 driver

On Fri, 2018-06-29 at 22:49 -0400, Simon Que wrote:
> The Gasket (Google ASIC Software, Kernel Extensions, and Tools) kernel
> framework is a generic, flexible system that supports thin kernel
> drivers. Gasket kernel drivers are expected to handle opening and
> closing devices, mmap'ing BAR space as requested, a small selection of
> ioctls, and handling page table translation (covered below). Any other
> functions should be handled by userspace code.
[]
> [PATCH v4]
> - Deleted unused field "base" in struct gasket_coherent_buffer
> - Moved maintainer info to top-level MAINTAINERS file
> [PATCH v5]
> - Updated drivers/staging/Makefile change to apply to gregkh's staging
>   tree.

Why delete all the logging by adding if (false} tests
and then not mention it?