linux-kernel - Re: [PATCH 3/3] staging: rtl8192u: Prune the rtl819x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <63457910-E837-458B-A80D-9D73DAF33FF5@juzza.co.uk>
Date:   Sat, 30 Jun 2018 09:34:19 +0100
From:   Justin Skists <justin.skists@...za.co.uk>
To:     driverdev-devel@...uxdriverproject.org,
        John Whitmore <johnfwhitmore@...il.com>,
        devel@...verdev.osuosl.org
CC:     kstewart@...uxfoundation.org, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org, pombredanne@...b.com,
        tglx@...utronix.de
Subject: Re: [PATCH 3/3] staging: rtl8192u: Prune the rtl819x_HT.h file of unused definitions.



On 29 June 2018 19:10:07 BST, John Whitmore <johnfwhitmore@...il.com> wrote:
>There are two files named "rtl819x_HT.h"
>
>$ find . -name rtl819x_HT.h -print
>./drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h
>./drivers/staging/rtl8192e/rtl819x_HT.h
>
>The two files are very similar but differ slightly. Unsed definitions
>have
>been removed from "drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h" as
>a first
>step towards possibly merging the two files into one.

Just delete the lines if they are unused. Don't worry about commenting them out. That way it is easier to visually diff the patches for review. (Plus, the previous code is never lost in the git tree, anyway)

:-)

Justin