linux-kernel - Re: [PATCH v3 0/2] Detect & register virtio-crypto algos only if it can be supported by backend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180701131855.5sjnvyvhiq7ktzg3@gondor.apana.org.au>
Date:   Sun, 1 Jul 2018 21:18:55 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Farhan Ali <alifm@...ux.ibm.com>
Cc:     linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        kvm@...r.kernel.org, qemu-devel@...gnu.org, borntraeger@...ibm.com,
        arei.gonglei@...wei.com, longpeng2@...wei.com, pasic@...ux.ibm.com,
        frankja@...ux.ibm.com, jasowang@...hat.com, mst@...hat.com
Subject: Re: [PATCH v3 0/2] Detect & register virtio-crypto algos only if it
 can be supported by backend

On Tue, Jun 19, 2018 at 11:41:32AM -0400, Farhan Ali wrote:
> Hi,
> 
> Currently the Linux virtio-crypto driver registers the crypto
> algorithm without verifying if the backend actually supports the
> algorithm.
> 
> This kernel patch series adds support for registering algorithm
> with Linux crypto layer, only if the algorithm is supported by
> the backend device. This also makes the driver more compliant with
> the virtio-crypto spec [1].
> 
> I would appreciate any feedback or comments on this.
> 
> Thank you
> Farhan
> 
> Reference
> ---------
> [1] Virtio crypto spec proposal https://lists.gnu.org/archive/html/qemu-devel/2017-12/msg00816.html
> 
> ChangeLog
> ---------
> v2 -> v3
>     - Add Christian Borntrager's acks for the patches.
> 
> v1 -> v2
>    - Modify comment as suggested by Arei (patch 1)
>    - Modify error message as suggested by Arei (patch 2)
> 
> Farhan Ali (2):
>   crypto/virtio-crypto: Read crypto services and algorithm masks
>   crypto/virtio-crypto: Register an algo only if it's supported
> 
>  drivers/crypto/virtio/virtio_crypto_algs.c   | 112 ++++++++++++++++++---------
>  drivers/crypto/virtio/virtio_crypto_common.h |  25 +++++-
>  drivers/crypto/virtio/virtio_crypto_core.c   |  29 +++++++
>  drivers/crypto/virtio/virtio_crypto_mgr.c    |  81 +++++++++++++++++--
>  4 files changed, 202 insertions(+), 45 deletions(-)

All applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt