linux-kernel - Re: [PATCH v5] ARM: dts: imx51-zii-rdu1: fix touchscreen pinctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 1 Jul 2018 11:20:29 +0800
From:   Shawn Guo <shawnguo@...nel.org>
To:     Nick Dyer <nick@...anahar.org>
Cc:     Sascha Hauer <s.hauer@...gutronix.de>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, Fabio Estevam <festevam@...il.com>,
        Andrey Smirnov <andrew.smirnov@...il.com>,
        Nikita Yushchenko <nikita.yoush@...entembedded.com>,
        Chris Healy <cphealy@...il.com>,
        Lucas Stach <l.stach@...gutronix.de>, stable@...r.kernel.org
Subject: Re: [PATCH v5] ARM: dts: imx51-zii-rdu1: fix touchscreen pinctrl

On Thu, Jun 21, 2018 at 07:10:00PM +0100, Nick Dyer wrote:
> The pinctrl settings were incorrect for the touchscreen interrupt line, causing
> an interrupt storm. This change has been tested with both the atmel_mxt_ts and
> RMI4 drivers on the RDU1 units.
> 
> The value 0x4 comes from the value of register IOMUXC_SW_PAD_CTL_PAD_CSI1_D8
> from the old vendor kernel.
> 
> Signed-off-by: Nick Dyer <nick@...anahar.org>
> Fixes: ceef0396f367 ("ARM: dts: imx: add ZII RDU1 board")
> Cc: <stable@...r.kernel.org> # 4.15+
> Reviewed-by: Fabio Estevam <fabio.estevam@....com>
> Tested-by: Chris Healy <cphealy@...il.com>

Applied, thanks.

> ---
> Changes in v5:
> - Add tested by Chris Healy
> Changes in v4:
> - Add reviewed by Fabio

You do not have to send new version just for collecting review and test
tags.  I will do that when applying.

Shawn

> Changes in v3:
> - Update commit message to add source of 0x4 value, fixes tag and CC stable
> Changes in v2:
> - Use hex, only alter IRQ line config
> 
>  arch/arm/boot/dts/imx51-zii-rdu1.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/imx51-zii-rdu1.dts b/arch/arm/boot/dts/imx51-zii-rdu1.dts
> index df9eca94d812..8a878687197b 100644
> --- a/arch/arm/boot/dts/imx51-zii-rdu1.dts
> +++ b/arch/arm/boot/dts/imx51-zii-rdu1.dts
> @@ -770,7 +770,7 @@
>  
>  	pinctrl_ts: tsgrp {
>  		fsl,pins = <
> -			MX51_PAD_CSI1_D8__GPIO3_12		0x85
> +			MX51_PAD_CSI1_D8__GPIO3_12		0x04
>  			MX51_PAD_CSI1_D9__GPIO3_13		0x85
>  		>;
>  	};
> -- 
> 2.17.1
>