lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 1 Jul 2018 10:36:48 +0200 From: Jessica Yu <jeyu@...nel.org> To: Joe Perches <joe@...ches.com> Cc: linux-kernel@...r.kernel.org, David Howells <dhowells@...hat.com> Subject: Re: [PATCH] modsign: log module name in the event of an error +++ Joe Perches [29/06/18 21:04 -0700]: >On Fri, 2018-06-29 at 17:53 +0200, Jessica Yu wrote: >> Now that we have the load_info struct all initialized (including >> info->name, which contains the name of the module) before >> module_sig_check(), make the load_info struct and hence module name >> available to mod_verify_sig() so that we can log the module name in the >> event of an error. >[] >> diff --git a/kernel/module-internal.h b/kernel/module-internal.h >[] >> +extern int mod_verify_sig(const void *mod, struct load_info *info, >> + unsigned long *_modlen); >> diff --git a/kernel/module.c b/kernel/module.c >[] >> @@ -2778,7 +2758,7 @@ static int module_sig_check(struct load_info *info, int flags) >> memcmp(mod + info->len - markerlen, MODULE_SIG_STRING, markerlen) == 0) { >> /* We truncate the module to discard the signature */ >> info->len -= markerlen; >> - err = mod_verify_sig(mod, &info->len); >> + err = mod_verify_sig(mod, info, &info->len); > >This is the only place this is used correct? >So why pass info and info->member? > >info should be enough Ah yeah you're right, thanks! Jessica
Powered by blists - more mailing lists