linux-kernel - Re: [PATCH] crypto: testmgr: add test vectors for skein

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180701094719.GC9956@kroah.com>
Date:   Sun, 1 Jul 2018 11:47:19 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Herbert Xu <herbert@...dor.apana.org.au>
Cc:     Juan Manuel Torres Palma <j.m.torrespalma@...il.com>,
        Eric Biggers <ebiggers3@...il.com>,
        linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
        davem@...emloft.net
Subject: Re: [PATCH] crypto: testmgr: add test vectors for skein

On Sun, Jul 01, 2018 at 05:16:11PM +0800, Herbert Xu wrote:
> On Thu, Jun 21, 2018 at 07:12:47AM +0900, Juan Manuel Torres Palma wrote:
> > On Wed, Jun 20, 2018 at 11:10:51AM -0700, Eric Biggers wrote:
> > > Also, can you describe the users of Skein in the kernel?  If there are no users,
> > > there's no need to move it out of staging, or even have it in the kernel at all
> > > anymore.  I say that as someone who has had to volunteer to fix critical bugs
> > > found by fuzzing in crypto algorithms for which it's unclear why they are in the
> > > kernel at all, as there are no apparent users.
> > 
> > To be honest I'm not aware of anyone actually using Skein.
> > 
> > So by this are you suggesting that we drop support? If not removed, I believe
> > it's better to use test vectors as regression tests for further modifications.
> 
> Let's just remove skein.  In fact staging should never add generic
> crypto algorithms.

Ok, I'll go drop it.  I forgot why we added it in the first place, it
has been there for 4 years and not moved out, so it's not a problem to
drop it now.

thanks,

greg k-h