linux-kernel - Re: [PATCH] Input: elantech - Fix V4 report decoding for module with middle key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180701234419.GA250349@dtor-ws>
Date:   Sun, 1 Jul 2018 16:44:19 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     kt.liao@....com.tw,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-input <linux-input@...r.kernel.org>,
        ulrik.debie-os@...ig.org, phoenix@....com.tw,
        aaron.ma@...onical.com, josh.chen@....com.tw
Subject: Re: [PATCH] Input: elantech - Fix V4 report decoding for module with
 middle key

On Sun, Jul 01, 2018 at 04:30:44PM -0700, Linus Torvalds wrote:
> On Thu, Jun 21, 2018 at 5:16 PM Dmitry Torokhov
> <dmitry.torokhov@...il.com> wrote:
> >
> > OK, thank you for the info. Applied.
> 
> Ugh. Dmitry, please be more careful with author names.
> 
> Apparently you aren't in a proper utf-8 locale, and you messed up the
> name in the git repository. So yoiu apparently tried to take KT Liao's
> Chinese name: 廖崇榮, but did so in some wrong locale, and it ended up
> being just '???' in the git repo.
> 
> And I only noticed when I did my shortlog for doing my 4.18-rc3 release notes.
> 
> I don't know what locale or tools you have, but please try to make
> sure everything is utf-8 aware so that these kinds of name corruptions
> don't happen..

Yeah, I noticed that when preparing pull request, but did not want to
rebase the branch that I always keep stable, sorry.

The reason it got messed up is I switched to pulling patches from
patchwork.kernel.org as it collects Acked-by and Reviewed-by tags so I
do not have to add them manually, but unfortunately it does not do
proper UTF-8:

https://patchwork.kernel.org/patch/10431971/

I have since reworked by scripts to only take changelog from patchwork,
and take author name/email from the mail message and using "git
mailinfo" which worked well before. Should not happen again.

Thanks.

-- 
Dmitry