linux-kernel - Re: [PATCH] MIPS: Remove no-op cast in show

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180702213928.35olwcekyg7shwow@pburton-laptop>
Date:   Mon, 2 Jul 2018 14:39:28 -0700
From:   Paul Burton <paul.burton@...s.com>
To:     Ralf Baechle <ralf@...ux-mips.org>
Cc:     linux-mips@...ux-mips.org, James Hogan <jhogan@...nel.org>,
        Julia Lawall <julia.lawall@...6.fr>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MIPS: Remove no-op cast in show_regs()

Hi Ralf,

On Mon, Jul 02, 2018 at 05:20:29PM +0200, Ralf Baechle wrote:
> On Fri, Jun 22, 2018 at 11:07:03AM -0700, Paul Burton wrote:
> 
> > In show_regs() we have a regs argument of type struct pt_regs *, and we
> > explicitly cast it to that same type as part of calling __show_regs().
> > 
> > Casting regs to the same type that it is declared as does nothing at
> > all, so remove the useless cast.
> 
> Good catch but there's no dump_stack() in v4.18-rc3 so this doesn't apply.

dump_stack() is there in mips-fixes as part of fixing up
arch_trigger_cpumask_backtrace(), so this would apply once the next
fixes pull happens.

But I'm all for cleaning up other instances too.

Thanks,
    Paul